Re: [v3] RFC make check-abi, round 2

[Loren James Rittle <rittle at latour dot rsch dot comm dot mot dot com>]

In article <200208220654.g7M6sQc05619@fillmore.constant.com> Benjamin wrote:

> Incorporating comments from today...... this is the first non-invasive
> patch, meaning people using non-linux, people doing crosses, etc are
> all ok. I think this is ready to be checked in, but I'll give a 24
> hour comment period.

I have applied your patch.  Rebuilt in place (and then in an attempt
to verify that the issues go away, also from scratch).  Looks very
close; and since they don't break bootstrap, I'd say install anyway.

(I staged libstdc++-v3/config/abi/i386-unknown-freebsd4.6/baseline_symbols.txt
 We need a Makefile rule to install a new baseline... ;-)

S rittle@latour; gmake check-abi
(cd testsuite; \
  abi_check /usr/users/rittle/outside-cvs-src/gcc-mainline/libstdc++-v3/config/abi/i386-unknown-freebsd4.6/baseline_symbols.txt @test_lib@)
Usage:  abi_check baseline_file
gmake: [check-abi] Error 1 (ignored)

@test_lib@ was unexpanded in generated Makefile (since it is possible
that I didn't regen automake targets properly, perhaps ignore this for now)

I manually edited the make file to remove all trace of test_lib and
then reran:

S rittle@latour; gmake check-abi
(cd testsuite; \
  abi_check /usr/users/rittle/outside-cvs-src/gcc-mainline/libstdc++-v3/config/abi/i386-unknown-freebsd4.6/baseline_symbols.txt)
Syntax error: Bad fd number
Unable to generate the list of exported symbols.
gmake: [check-abi] Error 2 (ignored)

Note: If you need a particular shell to run the command line
(i.e. bash in this case), I think you need to force it to be used.  I
will rewrite it to use plain /bin/sh and/or convert more to plain C++
code after you check-in (if this is OK with you).

Regards,
Loren