This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH,RFC] Change __convert_from_v to use snprintf and use it



> Please let me know what do you think of it, if perhaps may be only viable for the head,
> being to invasive. Tested i686-pc-linux-gnu.

I think the changed signature of __convert_from_v should be checked in, 
even if nothing is done with it at the moment.

Also, the testsuite entries.

Furthermore,

> I have just learned :-( that snprintf is only part of C99, not of C89,
> despite being quite widespread. Therefore, we cannot assume it to be
> available on systems using glibc2.0.x or whatever not C99 compliant. 

....just means that a check for snprintf should be added to

acinclude.m4/GLIBCPP_ENABLE_C99

and the code conditionalized, like

#if _GLIBCPP_USE_C99
//use snprintf
#else
//loose
#endif

-benjamin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]