This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix collate_members_char[wchar_t].cc


> So, shouldn't it be
>
> +  VERIFY(i2 > 0);
>
> ?

... on the other hand, I have just noticed, that in those testfiles, there are
only VERIFY with > 0 and < 0, no strict comparisons with +1 and -1.

What do you prefer:
1- (more strict) Changing all the > 0 to == +1 and all < 0 to == -1.
2- (less strict) Use in my changes too < 0 and > 0.

??

Ciao, Paolo.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]