This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] _M_replace (take3): better clean up + speed ups!!
- From: Paolo Carlini <pcarlini at unitus dot it>
- To: Phil Edwards <pedwards at disaster dot jaj dot com>
- Cc: libstdc++ at gcc dot gnu dot org
- Date: Mon, 10 Dec 2001 09:27:42 +0100
- Subject: Re: [PATCH] _M_replace (take3): better clean up + speed ups!!
- References: <3C13527A.48D1A661@unitus.it> <20011209222653.A24223@disaster.jaj.com>
Phil Edwards wrote:
> I'll leave commenting on this patch to others (I am not as familiar with
> string), but I'll mention this purely as a matter of form:
>
> > * include/bits/basic_string.tcc (_M_replace_safe): New.
> > * include/bits/basic_string.tcc (_M_replace(input_iterator_tag),
> > append members): use it.
> > * include/bits/basic_string.tcc (_M_replace(forward_iterator_tag)): Remove.
> > * include/bits/basic_string.h: Adjust declarations.
> > * src/string-inst.cc: Adjust declarations.
>
> Files are usually listed multiple times only when there are unreleated
> changes; for this patch, a better entry would be:
>
> * include/bits/basic_string.tcc (_M_replace_safe): New function.
> (_M_replace(input_iterator_tag), append members): Use it.
> (_M_replace(forward_iterator_tag)): Remove.
> * include/bits/basic_string.h: Adjust declarations.
> * src/string-inst.cc: Adjust declarations.
Thanks Phil. I will use the ChangeLog you suggest. Really, I have to learn how to write
ChangeLog from examples and sometimes I'm quite confused.
Paolo.