This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [3.0.1 and mainline] PATCH for libstdc++/3284


On Jul  2, 2001, Loren James Rittle <rittle@latour.rsch.comm.mot.com> wrote:

> !   AC_OUTPUT_COMMANDS([d=include/bits; a='[ABCDEFGHIJKLMNOPQRSTUVWXYZ_]'
>       rm -f $d/gthr.h $d/gthr-single.h $d/gthr-default.h
> !     sed '/^#/s/\('$a$a'*\)/_GLIBCPP_\1/g' <$d/gthr.h-in \

I'm afraid this is not good enough.  The presence of an unquoted
[ABCDE..._] will cause the shell to look for files named /^#/s/\(
followed by two capital letters or underscores, and then
*\)/_GLIBCPP_\1/g.  Of course, nobody would have a file named like
that, but why take the risk?  Please enclose $a in double quotes.
Similarly for the other occurrences of it.

Thanks for taking care of the problem!

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist    *Please* write to mailing lists, not to me


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]