Re: V3 PATCH: Insert `typename' and `ios_base::' whererequired

[Mark Mitchell <mark at codesourcery dot com>]

>>>>> "Benjamin" == Benjamin Kosnik <bkoz@redhat.com> writes:

    >> didn't get enough testing.  Turning that on doesn't work
    >> because the .tcc files that get included aren't legal C++.
    >> Bummer.

    Benjamin> weird. I bootstrapped it and tested it. I didn't notice
    Benjamin> any new failures, just the slowdown.

Weird indeed.  I figured you/Jeffrey had just checked it in because it
looked so obvious.  I got `make check-g++' failures aplenty.  Hmm.

    >> What I couldn't figure out how to fix, however, was:
    >> 
    >> int_type __plen = static_cast<size_t>(__newlen - __oldlen);
    >> char_type __pads[__plen];
    >> 
    >> and such in ostream.tcc.  This is invalid C++; it uses a
    >> variable-sized array.  The options are:
    >> 
    >> 1. Change the algorithm somehow.
    >> 
    >> 2. Dynamically allocate the memory.

    Benjamin> i'll look at it

Thanks!

--
Mark Mitchell                   mark@codesourcery.com
CodeSourcery, LLC               http://www.codesourcery.com