This is the mail archive of the
libstdc++@sources.redhat.com
mailing list for the libstdc++ project.
Re: A couple problems with c_io_stdio.cc
- To: snyder at fnal dot gov
- Subject: Re: A couple problems with c_io_stdio.cc
- From: Loren James Rittle <rittle at latour dot rsch dot comm dot mot dot com>
- Date: Tue, 21 Nov 2000 23:18:14 -0600 (CST)
- CC: libstdc++ at sourceware dot cygnus dot com
- References: <200011210440.WAA05938@d0sgibnl1.fnal.gov>
- Reply-to: rittle at rsch dot comm dot mot dot com
Hi Scott,
Regarding the patches you posted yesterday at:
http://gcc.gnu.org/ml/libstdc++/2000-11/msg00295.html
I would like to recommend that your first patch be installed ASAP.
Given the apparent usage of streamoff, it appears obviously correct to
me (at least on BSD, and according to the ANSI C89 standard, fseek is
supposed to return 0 unless the seek can't be satisfied).
It fixes the following test cases on i386-unknown-freebsd3.4:
-r 18 0.000 31333 2752 435531 21_strings/inserters_extractors.cc
-r 13 0.000 25045 2592 378982 27_io/filebuf.cc
-r 13 0.000 28413 2432 411453 27_io/istream_seeks.cc
Regarding your second patch, it appears (but unconfirmed) that it
would fix one area of this failing test case, but break the other side
of it:
-r 10 0.000 14229 1984 342491 27_io/filebuf_members.cc
Regards,
Loren