Re: V3 PATCH: Fix const-correctness in use of iconv

[Gabriel Dos Reis <gdr at codesourcery dot com>]

Mark Mitchell <mark@codesourcery.com> writes:

| >>>>> "Gabriel" == Gabriel Dos Reis <gdr@codesourcery.com> writes:
| 
|     Gabriel> That is fine. But I would like the ChangeLog entry be
|     Gabriel> descriptive about the intent since the signatures seems
|     Gabriel> to be changing.  That will help figure out latter why
|     Gabriel> things were done.
| 
| Well, the GNU Coding Standards say intent goes in code; changes go in
| ChangeLogs.  So I think what we need is a comment near the adapter
| function.

OK.  It has been practice in V3 to document the intent of ChangeLog
entries (especially for tricky issues) even if the code is documented,
it makes it easier to follow changes history.  Well, now V3 is
operating under GNU policies and I missed that :-)

| We're not changing the signatures of any C++ library functions; only
| changing their implementations.

I understood, the C++ library function signatures won't be changed.  I
was talking about the iconv stuff.  I should have have been clearer.
Sorry for the confusion. 

-- Gaby
CodeSourcery, LLC                       http://www.codesourcery.com