This is the mail archive of the libstdc++@sources.redhat.com mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: libstdc++/92: Bug in istream::get(basic_streambuf*);

To: stdc++ <libstdc++ at sourceware dot cygnus dot com>
Subject: Re: libstdc++/92: Bug in istream::get(basic_streambuf*);
From: brent at rcfile dot org
Date: Tue, 3 Oct 2000 03:53:06 -0400
Cc: libstdc++-prs at sourceware dot cygnus dot com, bgarcia at laurelnetworks dot com
References: <20001002051700.29946.qmail@sourceware.cygnus.com>

On 02 Oct 2000 at 05:17 (-0000), brent@rcfile.org wrote:
| The following reply was made to PR libstdc++/92; it has been noted by GNATS.
| 
| From: brent@rcfile.org
| To: bgarcia@laurelnetworks.com
| Cc: libstdc++-gnats@sourceware.cygnus.com
| Subject: Re: libstdc++/92: Bug in istream::get(basic_streambuf*);
| Date: Mon, 2 Oct 2000 01:20:11 -0400
| 
|  On 28 Sep 2000 at 17:23 (-0000), bgarcia@laurelnetworks.com wrote:
|  | >Environment:
|  | linux x86, libstdc++ v.2.90.8, gcc v 2.95.2
|  
|  verified that most recent cvs has this bug as well. thanks for the bug 
|  report. I'll provide a patch for this tomorrow.

patches attached. diffs made against each file where it lives.

testsuite failures with this patch applied:
-       -       22_locale/codecvt_unicode_char.cc
-       -       22_locale/codecvt_unicode_wchar_t.cc
-       -       22_locale/ctor_copy_dtor.cc
-       23_containers/map_operators.cc         (compilation failed)
-       23_containers/set_operators.cc         (compilation failed)
-       -       27_io/ios_base_callbacks.cc
-       -       27_io/ios_manip_fmtflags.cc

failures appear to all be unrelated to any code this patch affects.

ChangeLog entry:

2000-10-03  Brent Verner  <brent@rcfile.org>
	* bits/istream.tcc [basic_istream::get(basic_streambuf&)]:
    removed test for _M_gcount < in_avail(), as in_avail()
    only reports info for current buffer, causing method to
    return at end of buffer.
    http://sources.redhat.com/ml/libstdc++-prs/2000-q3/msg00041.html
  * testsuite/27_io/istream_unformatted.cc [test07()]: new test
  * testsuite/27_io/istream_unformatted-07.txt: new file

-- 
All opinions expressed are My own, unless otherwise attributed. In
presenting facts, I expressly reserve the right to be Wrong. Portions
of this message authored by Me are subject to the Free Thought License.

Index: istream.tcc
===================================================================
RCS file: /cvs/gcc/egcs/libstdc++-v3/bits/istream.tcc,v
retrieving revision 1.5
diff -c -p -3 -r1.5 istream.tcc
*** istream.tcc	2000/07/26 06:51:38	1.5
--- istream.tcc	2000/10/03 06:48:46
*************** namespace std {
*** 588,596 ****
  	    bool __testdelim = __c == __idelim;
  	    bool __testeof =  __c == __eof;
  	    bool __testput = true;
- 	    streamsize __n = __this_sb->in_avail();
  
! 	    while (_M_gcount <= __n && !__testeof && !__testdelim 
  		   && (__testput = __sb.sputc(traits_type::to_char_type(__c)) 
  		                   != __eof))
  	      {
--- 588,595 ----
  	    bool __testdelim = __c == __idelim;
  	    bool __testeof =  __c == __eof;
  	    bool __testput = true;
  
! 	    while (!__testeof && !__testdelim 
  		   && (__testput = __sb.sputc(traits_type::to_char_type(__c)) 
  		                   != __eof))
  	      {

Index: istream_unformatted.cc
===================================================================
RCS file: /cvs/gcc/egcs/libstdc++-v3/testsuite/27_io/istream_unformatted.cc,v
retrieving revision 1.5
diff -c -p -3 -r1.5 istream_unformatted.cc
*** istream_unformatted.cc	2000/08/14 19:59:25	1.5
--- istream_unformatted.cc	2000/10/03 07:25:49
*************** test06()
*** 452,457 ****
--- 452,478 ----
    return 0;
  }
  
+ // bug reported by bgarcia@laurelnetworks.com
+ // http://sources.redhat.com/ml/libstdc++-prs/2000-q3/msg00041.html
+ int
+ test07()
+ {
+   const char* tfn = "testsuite/istream_unformatted-07.txt";
+   std::ifstream infile;
+   infile.open(tfn);
+   VERIFY( infile );
+   while (infile)
+     {
+       std::string line;
+       std::ostringstream line_ss;
+       while (infile.peek() == '\n')
+         infile.get();
+       infile.get(*(line_ss.rdbuf()));
+       line = line_ss.str();
+       VERIFY( line == "1234567890" || line == "" );
+     }
+   return 0;
+ }
  
  int 
  main()
*************** main()
*** 462,476 ****
    test04();
    test05();
    test06();
!   
    return 0;
  }
- 
- 
- 
- 
- 
- 
- 
- 
  
--- 483,490 ----
    test04();
    test05();
    test06();
!   test07();
! 
    return 0;
  }

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]