This is the mail archive of the libstdc++@sourceware.cygnus.com mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Suggestions for libstdc++-2.90.6


> Not everything worked (not surprising!), and so I would like to
> submit some suggestions that made at least a number of things
> compile and work correctly.

Thanks for your patches! I 'm not a library maintainer, so I can't
comment on the content of the patches. However, I have a comment on
the form. Please don't use old-style diff; instead use unified diff
(diff -u) or context diff (diff -c).

Both have the advantage of being applicable even if the source is
slightly changed.  Whether to use unified or context is a matter of
taste; I find unified diffs to be more readable.

Also, -p is a nice option; it shows the function in which the patch
occurs.

Regards,
Martin

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]