On 06/05/2015 03:00 PM, David Malcolm wrote:
"jit" isn't part of "all" languages, and currently fails to build on the aldyh/debug-early branch:
The debug-early work is now in mainline. Feel free to commit when you deem appropriate, since you are the jit maintainer ;-).
static void
-jit_langhook_write_globals (void)
+jit_langhook_post_compilation_parsing_cleanups (void)
{
gcc::jit::playback::context *ctxt = gcc::jit::active_playback_ctxt;
gcc_assert (ctxt);
JIT_LOG_SCOPE (ctxt->get_logger ());
- ctxt->write_global_decls_1 ();
-
- /* This is the hook that runs the middle and backends: */
- symtab->finalize_compilation_unit ();
-
- ctxt->write_global_decls_2 ();
+ ctxt->finalize_global_decls ();
This hook gets called after the compilation proper has run, and we're trying to avoid it. We're trying to get all the front-ends to finish their thing and avoid depending on the compilation proper.
Can you not get this to work without running finalize_global_decls after the compilation proper? If not, then I see no problem with your patch....after all, C++ is still using this hook :(.
Thanks for working on this. Aldy