This is the mail archive of the java@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: libjava build failure with read-only source tree


On Thu, Sep 29, 2011 at 9:18 AM, Jan Beulich <JBeulich@suse.com> wrote:

> --- a/libjava/classpath/tools/Makefile.am
> +++ b/libjava/classpath/tools/Makefile.am
> @@ -371,6 +371,7 @@ endif
> ?## BEGIN GCJ LOCAL
> ? ? ? ?cp -pR $(srcdir)/asm .
> ? ? ? ?cp -pR $(srcdir)/classes .
> + ? ? ? find asm classes -type d -exec chmod u+w \{\} \;
> ? ? ? ?if [ -d asm/.svn ]; then \
> ? ? ? ? ?find asm classes -depth -type d -name .svn -exec rm -rf \{\} \;; \
> ? ? ? ?fi

This patch looks fine to me, though I wonder if there is any good
reason why "cp -p" was used in the first place?

In any case, I'd say you can go ahead and check this in under the
"obvious" rule.

Bryce


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]