This is the mail archive of the
java@gcc.gnu.org
mailing list for the Java project.
Re: found an overlapping data buffer in file natGCInfo.cc
- From: Andrew Haley <aph at redhat dot com>
- To: Martin Ettl <ettl dot martin at gmx dot de>
- Cc: java at gcc dot gnu dot org
- Date: Mon, 27 Jul 2009 12:03:09 +0200
- Subject: Re: found an overlapping data buffer in file natGCInfo.cc
- References: <20090727082913.78960@gmx.net>
On 07/27/2009 10:29 AM, Martin Ettl wrote:
> Hello,
>
> while checking the sources of gcc-4.4.1 with the static code analysis tool cppcheck i found an overlapping data buffer in file gcc-4.4.1/libjava/gnu/gcj/natGCInfo.cc at line 410.
>
> Take a look at the file:
>
> static void *
> nomem_handler(size_t size)
> {
> if (oomDumpName)
> {
> char temp[strlen(oomDumpName) + 20];
> 410 sprintf(temp, "%s%03d", temp, GC_dump_count++);
> printf("nomem_handler(%zd) called\n", size);
> gc_ok--;
> GC_enumerator x(temp);
> x.enumerate();
> gc_ok++;
> }
> return (void*)0;
> }
>
> Indeed, the buffer overlapps. This can lead to segmentation faults!
Thanks. How very weird; I wonder what that code was supposed to do.
Andrew.