This is the mail archive of the java@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Streamtokenizer

From: Andrew Haley <aph at redhat dot com>
To: Bryce McKinlay <bryce at mckinlay dot net dot nz>
Cc: Tom Tromey <tromey at redhat dot com>, OneGuy <oneguyks at gmail dot com>, java at gcc dot gnu dot org
Date: Sat, 10 May 2008 12:02:54 +0100
Subject: Re: Streamtokenizer
References: <d3910afe0805072014i53d4f848mb752654281d224e9@mail.gmail.com> <7230133d0805080537t520ffa58y89df51c13e281c2f@mail.gmail.com> <d3910afe0805080559h5930b894t5f00ee0952e347e5@mail.gmail.com> <7230133d0805081933i51c4827fm288d5a3b1dcef6e7@mail.gmail.com> <d3910afe0805082156n632726adt1ff569a14164dd90@mail.gmail.com> <7230133d0805082232hb5ad988p4131b81cd0f092cd@mail.gmail.com> <d3910afe0805090249o3b09223i2f1f215207741b28@mail.gmail.com> <48242C9B.30200@redhat.com> <d3910afe0805090802o6fe7fb4am47cfdb9b77e467d9@mail.gmail.com> <m3r6cbebg3.fsf@fleche.redhat.com> <7230133d0805091736n50beef71w15e04ccb5aeee3c1@mail.gmail.com>

Bryce McKinlay wrote:
> On Sat, May 10, 2008 at 3:36 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>>> "OneGuy" == OneGuy  <oneguyks@gmail.com> writes:
>> OneGuy> Memory usage was even worse (55 MB with Classpath vs 35 MB with Sun's).
>>
>> It looks like our nextToken will often create a new StringBuffer.
>> Perhaps it would be better to make one and cache it.
>>
>> FWIW I'd accept a clean patch to further optimize StreamTokenizer.
>> Most likely the only reason it performs poorly is that it never popped
>> up as a performance limiter before.
> 
> Double.parseDouble() could also be used, avoiding creating a Double each time.
> 
> I haven't really been following this stuff, but what is the situation
> with merging in stuff from OpenJDK? It looks like they have a better
> implementation here which could very easily be dropped in.


GNU Classpath is a GNU project, and copyright in all GNU projects
must be assigned to the Free Software Foundation.  You can combine
code from the two projects, but we can't do that.

Andrew.

Follow-Ups:
- Re: Streamtokenizer
  - From: Andrew Haley

References:
- Streamtokenizer
  - From: OneGuy
- Re: Streamtokenizer
  - From: Bryce McKinlay
- Re: Streamtokenizer
  - From: OneGuy
- Re: Streamtokenizer
  - From: Andrew Haley
- Re: Streamtokenizer
  - From: OneGuy
- Re: Streamtokenizer
  - From: Tom Tromey
- Re: Streamtokenizer
  - From: Bryce McKinlay

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]