This is the mail archive of the java@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to enable libgcj.dll for MinGW


> Why?  It's a simple optimization that works perfectly well on most
> platforms.  We could have a target-specific diable for this.
I don't see any place in libgcj where this is being used (I haven't
done an exhaustive search) outside of natLogger.cc, which is where I
was experiencing the problem.  In any case, inlining virtual methods
like this doesn't seem right.  What if I wanted to override the getter
in a subclass.  The native code would still be using the original
implementation.  Granted this would be rare but correct usage.  What
gjavah is doing now is semantically incorrect.  The fact that it
breaks when linking PE binaries just brought the problem to light for
me.

TJ


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]