Re: Filenames with accented characters

[João Garcia <jgarcia at uk2 dot net>]

Hi Mohan,

Mohan Embar wrote:

> Like Ranjit, I too didn't take anything you said as a personal attack.
> On the contrary, I appreciate the knowledge you have on this subject
> and your efforts to remedy it.
>
>  
I know that. Besides that you have always replayed to my posts! ;-)

But are you the only one to decide if a patch is included or not in FSF 
sources?

I do not see any valid reason not to include a simple and working patch 
(even if you have a great plan for the future)!
And there are several simple and working patches, committed in the past 
to the FSF sources for other reasons, that are replaced for better and 
more complete ones!...

Even the original code for natFileWin32.java in 3.3 was missing 
free(buf) calls...

> characters in the source. Danny Smith philosophized over the inclusion
> of libiconv in mingw32-gcc, but as far as I know, we haven't gotten
> to the root of this problem yet:
>
>  
Is this a *real* and logic reason not to include a temporary patch, at 
least, in 3.3?

> If libiconv were part of the solution, this could potentially change
> our implementation.
>  
No. You would only have to call it instead of MultiByteToWideChar()!
And this is another strong reason to choose my temporary solution for 
now (why loose time changing every thing to wchar_t?)!

In 3.4, you almost don't change code to put my suggestion working! And 
you can use my suggestion to fix all the IO library with respect to this 
matter.
In the future, you only have to drop the Win32 form JV_TEMP_UTF and 
JvNewUTFString!

And we can still make that simple suggestion evolve to your original 
suggestion!

I will not comment on your other arguments for now... But I do not agree 
with some of them.

João