This is the mail archive of the
java@gcc.gnu.org
mailing list for the Java project.
Re: GC failure w/ THREAD_LOCAL_ALLOC ?
- From: Michael Smith <msmith at spinnakernet dot com>
- To: "Boehm, Hans" <hans_boehm at hp dot com>
- Cc: "'tromey at redhat dot com'" <tromey at redhat dot com>, "'Jeff Sturm '"<jsturm at one-point dot com>, "''Bryce McKinlay ' '" <bryce at waitaki dot otago dot ac dot nz>, "'java at gcc dot gnu dot org'" <java at gcc dot gnu dot org>
- Date: Mon, 01 Apr 2002 11:07:48 -0500
- Subject: Re: GC failure w/ THREAD_LOCAL_ALLOC ?
- References: <40700B4C02ABD5119F000090278766443BF13A@hplex1.hpl.hp.com>
Boehm, Hans wrote:
> I have seen no more failures with the patch, so far. And I did
> finally reproduce them without it. It would be interesting if
> particularly Jeff and Michael could confirm that. (Michael - you
> already had some of the other changes, so this probably won't apply
> cleanly without backing those out.)
I managed to manually merge them in, except:
> Index: linux_threads.c
> ===================================================================
> RCS file: /cvs/gcc/gcc/boehm-gc/linux_threads.c,v
> retrieving revision 1.18.2.1
> diff -u -r1.18.2.1 linux_threads.c
> --- linux_threads.c 2002/03/25 18:23:36 1.18.2.1
> +++ linux_threads.c 2002/03/29 02:15:18
[snip]
> @@ -544,7 +546,7 @@
> ABORT("pthread_attr_getstacksize failed\n");
> if (old_size < MIN_STACK_SIZE) {
> if (pthread_attr_setstacksize(&attr, MIN_STACK_SIZE) != 0)
> - ABORT("pthread_attr_getstacksize failed\n");
> + ABORT("pthread_attr_setstacksize failed\n");
> }
> }
> # endif /* HPUX */
this hunk didn't apply -- the code doesn't seem to even exist in my
version. Doesn't appear to matter though: a) the change does not appear
to be substantial, and b) HPUX isn't defined, so it probably wouldn't
have touched this anyway. :)
With the rest of the changes applied, I can no longer replicate the
problem using GCTest.
Thanks Hans!
Do you recommend running without GC_IGNORE_GCJ_INFO now that this fix is in?
regards,
michael