This is the mail archive of the
java@gcc.gnu.org
mailing list for the Java project.
Re: WIN-28: fix POSIX file descriptor numbering assumptions
- From: Bryce McKinlay <bryce at waitaki dot otago dot ac dot nz>
- To: Adam Megacz <patches at lists dot megacz dot com>
- Cc: java at gcc dot gnu dot org
- Date: Tue, 26 Feb 2002 12:34:28 +1300
- Subject: Re: WIN-28: fix POSIX file descriptor numbering assumptions
- References: <86y9hho46v.fsf@megacz.com>
Adam Megacz wrote:
>ok to commit?
>
> - a
>
>2002-02-25 Adam Megacz <adam@xwt.org>
>
> * java/io/FileDescriptor.java: We now use getFD**().
> * java/io/natFileDescriptorWin32.cc (getFDin, getFDout,
> getFDerr): Added these.
> * java/io/natFileDescriptorPosix.cc (getFDin, getFDout,
> getFDerr): Added these.
> * java/io/natFileDescriptorEcos.cc (getFDin, getFDout,
> getFDerr): Added these.
>
Is a file descriptor on windows really an int, or is it a pointer? If
its the latter, I don't think we should cast it to an int because it
will break on 64-bit.
I recall seeing a patch from Jeff a long time ago to fix FileDescriptor
to be more portable and not make the POSIX file-descriptor-is-an-int
assumption, but it never got checked in.
regards
Bryce.