Re: Correction to last message, GC status

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Hans" == Boehm, Hans <hans_boehm@hp.com> writes:

Hans> I would like to check the 6.0alpha8 changes and the attached
Hans> patch into the trunk early next week, after I return from a
Hans> conference.  Does this look OK?

Largely.  See below.

How is the 6.0alpha8 import being done?  Are you switching to using
the gcc tree as the main repository?  If so then we don't need to do
all the cvs shennanigans (though it might still be nice).  If not we
should probably do them.  I can point you at some relatively generic
instructions on how to do this, or I could try to find the time to do
the import myself...

We need ChangeLog entries before these patches can go in.  I can point
you at the docs for how to write them if you like.

Hans> +#if 0
Hans>        if ((ptr_t) (Obj) >= GC_least_plausible_heap_addr \
Hans>  	  && (ptr_t) (Obj) <= GC_greatest_plausible_heap_addr) \
Hans>          PUSH_CONTENTS (Obj, Top, Limit, Source, Exit)
Hans> +#endif

Just delete old code.  No point in keeping it around; we can resurrect
it via cvs if we need to.

Hans>  static void * handle_out_of_memory(size_t)
Hans>  {
Hans>    _Jv_ThrowNoMemory();
Hans> +  /* NOT REACHED */
Hans> +  return 0;
Hans>  }

Do we need this?  I marked _Jv_ThrowNoMemory as `noreturn'; that
should suffice.  If we do still need it, it is ok.

Hans>  inline void *
Hans>  _Jv_AllocPtrFreeObj (jsize size, jclass klass)
Hans>  {
Hans> [ ... ]
Hans> +# ifdef THREAD_LOCAL_ALLOC
Hans> +    void * obj = GC_local_gcj_malloc(size);

Shouldn't that be `GC_local_gcj_malloc(size, klass->vtable)' ?
 
Hans> +AC_ARG_ENABLE(parallel-mark,

I wonder if these options are documented anywhere.

Tom