This is the mail archive of the
java-discuss@sourceware.cygnus.com
mailing list for the Java project.
Re: Integrating Win32 changes
- To: "Jon Beniston" <jb7216 at bristol dot ac dot uk>
- Subject: Re: Integrating Win32 changes
- From: Tom Tromey <tromey at cygnus dot com>
- Date: Mon, 17 Jan 2000 14:44:42 -0800 (PST)
- Cc: <java-discuss at sourceware dot cygnus dot com>
- References: <00a201bf612c$34204a90$010010ac@brookfield.net>
>>>>> "Jon" == Jon Beniston <jb7216@bristol.ac.uk> writes:
Jon> Also, for native files where just a few changes are needed, such
Jon> as prims.cc, I'm putting #ifdef __MINGW32__ around the platform
Jon> specific code. Is that cool? Where a lot of changes have to be
Jon> made I'm implementing them in a new file.
It really depends.
In some situations it might be better to rename files and have
completely new implementations for new OS "flavor" ports (eg, Windows
-vs - POSIX) just like we do for natFileDescriptor.
This is particularly desirable when the code in question already has a
lot of preprocessor stuff in it -- at some point splitting it up is
just cleaner.
Tom