This is the mail archive of the
java-discuss@sources.redhat.com
mailing list for the Java project.
RE: comparision of classpath and gcj java.io.StreamTokenizer
- To: "'Tom Tromey'" <tromey at cygnus dot com>, Oskar Liljeblad <osk at hem dot passagen dot se>
- Subject: RE: comparision of classpath and gcj java.io.StreamTokenizer
- From: Anthony Green <green at cygnus dot com>
- Date: Sun, 23 Jul 2000 10:26:18 -0700
- Cc: "java-discuss at sourceware dot cygnus dot com" <java-discuss at sourceware dot cygnus dot com>
- Organization: Red Hat
- Reply-To: "green at cygnus dot com" <green at cygnus dot com>
On Saturday, July 22, 2000 4:59 PM, Tom Tromey [SMTP:tromey@cygnus.com]
wrote:
> But, is paperwork even required for a change which is a merger of GPL
> code like this? Does anyone know the answer to that?
My guess is that it's ok. Most of the patch is documentation directly from
Classpath. There are a couple of trivial patches we would probably accept
without assignment, and then there are a number of methods that changed like
this:
private boolean isWhitespace(int ch)
{
- if (ch >= 0 && ch <= 255)
- return whitespace[ch];
-
- return false;
+ return (ch >= 0 && ch <= 255 && whitespace[ch]);
}
FWIW - the compiler output should be identical. I actually prefer the
original code.
(btw - thanks Oskar!)
AG