This is the mail archive of the
java-prs@gcc.gnu.org
mailing list for the Java project.
[Bug fastjar/13020] zip-style comments
- From: "wmahan at gmail dot com" <gcc-bugzilla at gcc dot gnu dot org>
- To: java-prs at gcc dot gnu dot org
- Date: 28 Aug 2005 22:18:29 -0000
- Subject: [Bug fastjar/13020] zip-style comments
- References: <20031112105339.13020.swhite@decisionsoft.com>
- Reply-to: gcc-bugzilla at gcc dot gnu dot org
------- Additional Comments From wmahan at gmail dot com 2005-08-28 22:18 -------
Hi, I submitted a different patch to the upstream FastJar sources at
http://sourceforge.net/tracker/index.php?func=detail&aid=1275036&group_id=426&atid=300426
before I noticed this bug. (It doesn't apply to the gcc tree, but it would be
simple to make a patch if desired.)
When a zip-style comment is present, the patch by Stephen White searches
backwards from the end for the central-header-end section to read the offset of
the central header, while my patch parses through the file from the beginning to
find the central header.
Either approach should fix the problem. My fix might be a little less efficient,
but I think Stephen's patch would fail if the comment happens to contain the
magic string 0x06054b50. I'm not sure if that ever happens in practice.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13020