This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Don't encode the minor version in the gcj abi version

From: Matthias Klose <doko at ubuntu dot com>
To: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
Cc: GCJ-patches <java-patches at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 28 Apr 2016 13:45:30 +0200
Subject: Re: [patch] Don't encode the minor version in the gcj abi version
Authentication-results: sourceware.org; auth=none
References: <5721C1D4 dot 8080807 at ubuntu dot com> <yddeg9q86v7 dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <ydd60v280q6 dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE>

On 28.04.2016 12:52, Rainer Orth wrote:

Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:

Matthias Klose <doko@ubuntu.com> writes:

Bumping the version from from 6.0.0 to 6.1.0 broke gcj, because the minor
version is still encoded in the gcj abi, not seen during development of the
6 series until it was bumped for the final release.


This is PR java/70839.


I just noticed that your patch is incomplete: it leaves the now unused
minor around and incorrectly talks about sub-minor versions...

Here's what I had in the PR instead:

2016-04-28  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	PR java/70839
	* decl.c (parse_version): Remove minor handling.


yes, that looks good. Can't approve it myself.

Follow-Ups:
- Re: [patch] Don't encode the minor version in the gcj abi version
  - From: Andrew Haley

References:
- [patch] Don't encode the minor version in the gcj abi version
  - From: Matthias Klose
- Re: [patch] Don't encode the minor version in the gcj abi version
  - From: Rainer Orth
- Re: [patch] Don't encode the minor version in the gcj abi version
  - From: Rainer Orth

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]