This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [build] Move unwinder to toplevel libgcc (v2)
- From: Paolo Bonzini <bonzini at gnu dot org>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Rainer Orth <ro at cebitec dot uni-bielefeld dot de>, "Joseph S. Myers" <joseph at codesourcery dot com>, gcc-patches at gcc dot gnu dot org, Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>, Ian Lance Taylor <iant at google dot com>, Steve Ellcey <sje at cup dot hp dot com>, Richard Earnshaw <richard dot earnshaw at arm dot com>, Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>, Nick Clifton <nickc at redhat dot com>, Douglas Rupp <rupp at gnat dot com>, Tristan Gingold <gingold at adacore dot com>, Mike Stump <mikestump at comcast dot net>, Kaz Kojima <kkojima at gcc dot gnu dot org>, David Edelsohn <dje dot gcc at gmail dot com>, Sterling Augustine <augustine dot sterling at gmail dot com>, Arnaud Charlet <charlet at adacore dot com>, java-patches at gcc dot gnu dot org, Nicola Pero <nicola dot pero at meta-innovation dot com>, libstdc++ at gcc dot gnu dot org, Richard Sandiford <rdsandiford at googlemail dot com>
- Date: Thu, 11 Aug 2011 21:52:58 +0200
- Subject: Re: [build] Move unwinder to toplevel libgcc (v2)
- References: <ydd1ux2oc1u.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <Pine.LNX.4.64.1108101332410.28612@digraph.polyomino.org.uk> <yddzkjhl6oh.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <Pine.LNX.4.64.1108101348590.28612@digraph.polyomino.org.uk> <yddvcu5l694.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <4E42AACB.2080802@gnu.org> <yddfwl9l0az.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <4E42B494.9010309@gnu.org> <yddhb5oj7l3.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <CAMe9rOrznkTrvxg-KC4TrNF5uSua654p_1R0GZ-9rkNUF5Z76A@mail.gmail.com>
On Thu, Aug 11, 2011 at 20:19, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Aug 11, 2011 at 8:23 AM, Rainer Orth
> <ro@cebitec.uni-bielefeld.de> wrote:
>> Paolo Bonzini <bonzini@gnu.org> writes:
>>
>>> On 08/10/2011 06:05 PM, Rainer Orth wrote:
>>>>>> >> ?True: it is called once per multilib.
>>>>> >
>>>>> > ?Just to doublecheck, are we sure that unwind.h is always the same?
>>>> Yep: it's unwind-generic.h for almost all targets, just a few arm
>>>> targets use config/arm/unwind-arm.h for all multilibs.
>>>
>>> Patch doing rm -f is preapproved then.
>>
>> Here's what I installed, after making libgcc/unwind-generic.h read-only,
>> reconfiguring and rebuilding first without and with the patch and
>> observe the bug gone on i386-pc-solaris2.10.
>>
>> ? ? ? ?Rainer
>>
>>
>> 2011-08-11 ?Rainer Orth ?<ro@CeBiTec.Uni-Bielefeld.DE>
>>
>> ? ? ? ?* Makefile.in (install-unwind_h): Remove destination file first.
>>
>> diff --git a/libgcc/Makefile.in b/libgcc/Makefile.in
>> --- a/libgcc/Makefile.in
>> +++ b/libgcc/Makefile.in
>> @@ -994,6 +994,7 @@ gcc-extra-parts:
>> ?all: $(extra-parts)
>>
>> ?install-unwind_h:
>> + ? ? ? rm -f $(gcc_objdir)/include/unwind.h
>> ? ? ? ?cp unwind.h $(gcc_objdir)/include/unwind.h
>> ? ? ? ?chmod a+r $(gcc_objdir)/include/unwind.h
>>
>
> It breaks bootstrap with "make -j12" on a 24 core Linux/x86-64 ?:
>
> http://gcc.gnu.org/ml/gcc-regression/2011-08/msg00179.html
>
> rm -f ../../.././gcc/include/unwind.h
> cp unwind.h ../../.././gcc/include/unwind.h
> rm -f ../.././gcc/include/unwind.h
> chmod a+r ../../.././gcc/include/unwind.h
> cp unwind.h ../.././gcc/include/unwind.h
> chmod: cannot access `../../.././gcc/include/unwind.h': No such file
> or directory
> make[8]: *** [install-unwind_h] Error 1
> make[8]: *** Waiting for unfinished jobs....
> chmod a+r ../.././gcc/include/unwind.h
>
> We may have a race condition here.
Will take a look tomorrow.
Paolo