This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH][JAVA] Build a correct tree for rewritten method invocations
- From: Andrew Haley <aph at redhat dot com>
- To: java-patches at gcc dot gnu dot org
- Date: Wed, 03 Aug 2011 09:40:55 +0100
- Subject: Re: [PATCH][JAVA] Build a correct tree for rewritten method invocations
- References: <1312314963-5829-1-git-send-email-peter@pcc.me.uk>
On 08/02/2011 08:56 PM, Peter Collingbourne wrote:
> The Java frontend currently produces an incorrectly typed tree if
> a method call is rewritten. Specifically, the callee operand is a
> NOP_EXPR casting the address of the target method to the original
> method type. This patch causes the NOP_EXPR cast to use the type of
> the target method instead.
>
> The bug is exposed by dragonegg which requires the callee type to be
> correct.
>
> libjava tested, x86_64-unknown-linux-gnu.
>
> 2011-08-02 Peter Collingbourne <peter@pcc.me.uk>
>
> * expr.c (expand_invoke) Use the type of the method rewrite target.
Yes, I see. This looks OK.
Two questions:
Did you run the libjava test suite?
Do you have commit access?
Andrew.