Re: libjava patches for RTEMS

[Bryce McKinlay <bmckinlay at gmail dot com>]

On Tue, Jul 5, 2011 at 3:14 PM, Andrew Haley <aph@redhat.com> wrote:

>> As the testsuite result is good enough, I think it's time to ?get the
>> patch reviewed and merged into gcc. The patch is attached. :)
>
> Ah, 94 failures?

There isn't a minimum criteria on testsuite passes for new ports.
Presumably that's an improvement on before the patch.

However, I do have some concerns about the patch itself:

1. rtems-threads.cc seems to be just a copy of posix-threads.cc (if
there are differences, it wasn't obvious to me from reading the
patch). The rtems port should just use posix-threads like everything
else - if minor changes are needed, use configure #ifdefs.

2. It's bad form to make code conditional based on the OS name, ie:
"#if !defined(__rtems__)". Instead, it should be conditional on the
feature/function name using autoconf, like "#ifndef HAVE_GETHOSTNAME".
If the existing configure tests aren't sufficient or aren't working,
then you'd need to figure out why.

3. configure has been modified, but there's no corresponding patch to
configure.ac?

Bryce