This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] move libiconv linkage from libgcj.spec.in to libgcj_la_LDFLAGS
- From: Andrew Haley <aph at redhat dot com>
- To: java-patches at gcc dot gnu dot org
- Date: Mon, 20 Jun 2011 10:41:58 +0100
- Subject: Re: [PATCH] move libiconv linkage from libgcj.spec.in to libgcj_la_LDFLAGS
- References: <20110618055143.GA30332@bromo.med.uc.edu>
On 18/06/11 06:51, Jack Howarth wrote:
> The attached patch moves the linkage on $(LDLIBICONV) from libgcj.spec.in to a more correct
> direct linkage on libgcj which contains the unresolved symbols. This change also solves problems
> when a multilib only has libiconv for one of the two architectures (ie building gcc trunk on
> x86_64 fink which lacks a i386 libiconv). Bootstrap and libjava regression tested on x86_64 darwin11.
> Okay for gcc trunk?
> Jack
>
> 2011-06-18 Jack Howarth <howarth@bromo.med.uc.edu>
>
> * libjava/libgcj.spec.in: Don't pass @LDLIBICONV@.
> * libjava/Makefile.am (libgcj_la_LDFLAGS): Pass @LDLIBICONV@.
> * libjava/Makefile.in: Regenerate.
I think so, and this seems obvious, but there must have been some reason
why this was done. It'd be nice to figure out what that was.
Andrew.