Re: PATCH: Avoid command line length limit building tools.zip (PR libgcj/38251)

[Andrew Haley <aph at redhat dot com>]

On 03/02/2010 11:06 AM, Rainer Orth wrote:
> Hi Ralf,
> 
>>> --- a/libjava/classpath/tools/Makefile.am       Mon Jan 11 04:28:36 2010 +0000
>>> +++ b/libjava/classpath/tools/Makefile.am       Wed Jan 20 17:49:17 2010 +0100
>>> @@ -373,6 +373,9 @@
>>>  ## BEGIN GCJ LOCAL
>>>         cp -pR $(srcdir)/asm .
>>>         cp -pR $(srcdir)/classes .
>>> +       if [ -d asm/.svn ]; then \
>>> +         find asm classes -depth -type d -name .svn -exec rm -rf \{\} \;; \
>>> +       fi
>>>  ## END GCJ LOCAL
>>
>> FWIW, this has the potential to corrupt a SVN source tree iff the build
>> tree and the source trees happen to coincide.
> 
> right, that occured to me some time ago.
> 
>> I have to admit that I haven't tested building GCC in-tree for a few
>> months now, but after fixing a couple of nasty bugs in this area around
>> 09/2009, it used to work well for me.  Don't remember if I built java
>> for those tests, but I usually do.
> 
> I've no idea if any developer does in-tree builds anymore.  If so, I'm
> not sure even the cp -pR part is guaranteed to work.  And end-users who
> do are probably building from a tarball and don't care about a SVN
> checkout anyway.
> 
> Thoughts?

Either  a) don't do this, or b) issue an error if a user tries
to configure in-tree.

Andrew.