This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: PR gcc/42525: Avoid tr '\n', for Solaris /usr/bin/tr.
- From: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>
- To: gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
- Cc: bonzini at gnu dot org
- Date: Sat, 16 Jan 2010 13:25:41 +0100
- Subject: Re: PR gcc/42525: Avoid tr '\n', for Solaris /usr/bin/tr.
- References: <20100107205235.GD10462@gmx.de>
Ping <http://gcc.gnu.org/ml/gcc-patches/2010-01/msg00350.html>
* Ralf Wildenhues wrote on Thu, Jan 07, 2010 at 09:52:36PM CET:
> Bootstrapped and regtested on x86_64-unknown-linux-gnu.
> This patch has a couple of typos fixed over the one posted in
> <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42525#c1>.
>
> OK for trunk? This should be safe for ASCII hosts, according to the
> portability section of the Autoconf manual.
>
> An alternative way to "fix" this PR would be to change this
> recommendation in install.texi for *-*-solaris2*:
>
> The build process works more smoothly with the legacy Sun tools so,
> if you have `/usr/xpg4/bin' in your `PATH', we recommend that you place
> `/usr/bin' before `/usr/xpg4/bin' for the duration of the build.
> Avoid tr '\n', for Solaris /usr/bin/tr.
>
> contrib/ChangeLog:
> 2010-01-07 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
>
> * check_warning_flags.sh: Use \012 instead of \n with tr.
>
> gcc/ChangeLog:
> 2010-01-07 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
>
> PR gcc/42525
> * Makefile.in (write_entries_to_file, install-plugin):
> Use \012 instead of \n with tr.
>
> libjava/ChangeLog:
> 2010-01-07 Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
>
> * Makefile.am (write_entries_to_file): Use \012 instead of \n
> with tr.
> * sources.am (java/lang.list): Likewise.
> * Makefile.in: Regenerate.
>
> diff --git a/contrib/check_warning_flags.sh b/contrib/check_warning_flags.sh
> index eb53832..155b400 100755
> --- a/contrib/check_warning_flags.sh
> +++ b/contrib/check_warning_flags.sh
> @@ -147,7 +147,7 @@ remove_problematic_help_flags='
> /-$/d
> /=/d'
> help_flags=`
> - $CC --help -v 2>/dev/null | tr ' ' '\n' |
> + $CC --help -v 2>/dev/null | tr ' ' '\012' |
> sed -n '
> b a
> :a
> diff --git a/gcc/Makefile.in b/gcc/Makefile.in
> index 9e41f2a..9a5e539 100644
> --- a/gcc/Makefile.in
> +++ b/gcc/Makefile.in
> @@ -290,7 +290,7 @@ write_entries_to_file = $(shell rm -f $(2) || :) $(shell touch $(2)) \
> echo $$i; i=`expr $$i + $(write_entries_to_file_split)`; done), \
> $(shell echo "$(wordlist $(range), \
> $(shell expr $(range) + $(write_entries_to_file_split) - 1), $(1))" \
> - | tr ' ' '\n' >> $(2)))
> + | tr ' ' '\012' >> $(2)))
>
> # --------
> # UNSORTED
> @@ -4289,7 +4289,7 @@ install-plugin: installdirs lang.install-plugin s-header-vars
> # We keep the directory structure for files in config and .def files. All
> # other files are flattened to a single directory.
> $(mkinstalldirs) $(DESTDIR)$(plugin_includedir)
> - headers=`echo $(PLUGIN_HEADERS) | tr ' ' '\n' | sort -u`; \
> + headers=`echo $(PLUGIN_HEADERS) | tr ' ' '\012' | sort -u`; \
> srcdirstrip=`echo "$(srcdir)" | sed 's/[].[^$$\\*|]/\\\\&/g'`; \
> for file in $$headers; do \
> if [ -f $$file ] ; then \
> diff --git a/libjava/Makefile.am b/libjava/Makefile.am
> index f107684..11c60df 100644
> --- a/libjava/Makefile.am
> +++ b/libjava/Makefile.am
> @@ -26,7 +26,7 @@ write_entries_to_file = $(shell rm -f $(2) || :) $(shell touch $(2)) \
> echo $$i; i=`expr $$i + $(write_entries_to_file_split)`; done), \
> $(shell echo $(wordlist $(range), \
> $(shell expr $(range) + $(write_entries_to_file_split) - 1), $(1)) \
> - | tr ' ' '\n' >> $(2)))
> + | tr ' ' '\012' >> $(2)))
>
> ## ################################################################
>
> diff --git a/libjava/sources.am b/libjava/sources.am
> index 3f33a90..1ccc7b9 100644
> --- a/libjava/sources.am
> +++ b/libjava/sources.am
> @@ -4722,7 +4722,7 @@ java_lang_header_files = $(filter-out java/lang/Object.h java/lang/Class.h,$(pat
>
> java/lang.list: $(java_lang_source_files)
> @$(mkinstalldirs) $(dir $@)
> - echo $(srcdir)/classpath/lib/java/lang/*.class | tr ' ' '\n' | fgrep -v Object.class | fgrep -v Class.class | egrep -v '(Ecos|Posix|Win32)Process' > java/lang.list
> + echo $(srcdir)/classpath/lib/java/lang/*.class | tr ' ' '\012' | fgrep -v Object.class | fgrep -v Class.class | egrep -v '(Ecos|Posix|Win32)Process' > java/lang.list
>
> -include java/lang.deps