This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] Fix make closures.c use dlmmap,dlmunmap on cygwin.
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: Andrew Haley <aph at redhat dot com>
- Cc: Dave Korn <dave dot korn dot cygwin at googlemail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Rainer Emrich <rainer at emrich-ebersheim dot de>, Java Patches <java-patches at gcc dot gnu dot org>, libffi-discuss at sourceware dot org
- Date: Wed, 08 Jul 2009 15:23:20 +0100
- Subject: Re: [PATCH] Fix make closures.c use dlmmap,dlmunmap on cygwin.
- References: <4A535603.3010508@gmail.com> <4A5461AB.1050707@redhat.com>
Andrew Haley wrote:
> Dave Korn wrote:
>> [ Re: http://gcc.gnu.org/ml/gcc-patches/2009-06/threads.html#02228 ]
>>
>> Hey all,
>>
>> Take 2 of this patch. Works in the simplest way possible, by saying that
>> cygwin is an exception to the rule about win32/64 platforms not using the
>> local dlmmap/dlmunmap implementations.
>>
>> Sticklers for formatting will note that two of the #endif lines reach 81
>> characters, because of the comment repeating the #if condition. I didn't
>> think it was worth wrapping the lines for such a tiny excess length in
>> something this trivial, but I'll do so before committing if that's what the
>> maintainers decide.
>>
>> libffi/ChangeLog:
>>
>> * closures.c (mmap, munmap): Don't define replacement macros pointing
>> to dl* versions on windows platforms.
>>
>> Bootstrapping now. Assuming it completes and libffi tests run alright, OK?
>
> Sure: obvious/trivial, fixes bootstrap.
>
> Commit upstream and gcc trees, please.
>
> Andrew.
Doesn't bootstrap directly. Missing reference to `_is_selinux_enabled'.
Respin on the way. (Will probably just "#define is_selinux_enabled 0" for
cygwin.)
cheers,
DaveK