Re: [PATCH] Fix libgcj{,_bc}.so exports (PR libgcj/38872)

[Andrew Haley <aph at redhat dot com>]

Jakub Jelinek wrote:
> On Tue, Jan 27, 2009 at 09:35:26AM +0000, Andrew Haley wrote:
>> Jakub Jelinek wrote:
>>> libgcj_bc.so exports _Jv_CreateJavaVM, but libgcj.so.10 exports it
>>> as extern "C++" name, i.e. mangled.  The following patch changes
>>> it to extern "C" to match libgcj_bc.so and also removes one export
>>> from libgcj_bc.so for an extern inline cni.h function which shouldn't
>>> be ever undefined and libgcj.so.* never exported it.
>>>
>>> Bootstrapped/regtested on x86_64-linux, ok for trunk?
>> No, this breaks the ABI.  We need to keep the old version of _Jv_CreateJavaVM
>> as an alias.
> 
> _Z16_Jv_CreateJavaVMP14_Jv_VMInitArgs is being removed from libgcj.so.10
> only, and GCC 4.3 shipped libgcj.so.9.  So it only breaks ABI with programs
> built by earlier trunk snapshots, which I don't think we provide any
> guarantee for.

Ah yes, that's right.  This is OK.

Andrew.