This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] libjava support for AIX
- From: Tom Tromey <tromey at redhat dot com>
- To: "David Edelsohn" <dje dot gcc at gmail dot com>
- Cc: "GCC Patches" <gcc-patches at gcc dot gnu dot org>, "Java Patches" <java-patches at gcc dot gnu dot org>
- Date: Thu, 23 Oct 2008 14:09:41 -0600
- Subject: Re: [PATCH] libjava support for AIX
- References: <303e1d290810151652vcee0b93t50affde224baf2f2@mail.gmail.com>
- Reply-to: Tom Tromey <tromey at redhat dot com>
>>>>> "David" == David Edelsohn <dje.gcc@gmail.com> writes:
David> Index: classpath/native/fdlibm/fdlibm.h
David> #include <config.h>
David> #include <stdlib.h>
David> +#undef hz
Could you add a blank line between the #include and the #undef, and a
comment explaining why this is needed? Thanks.
This part should go into Classpath; I'll handle that.
David> +++ sysdep/powerpc/locks.h (working copy)
I don't know enough to review this bit. I'm inclined to take your
word for it, though, unless Andrew wants to take a look.
The rest is ok.
thanks,
Tom