Re: [patch] Import GNU Classpath (libgcj-import-20081021)

["Andrew John Hughes" <gnu_andrew at member dot fsf dot org>]

2008/10/22 Matthias Klose <doko@cs.tu-berlin.de>:
> This is a merge from the libgcj-import-20081022 tag into trunk,
> to resolve some whitespace differences in nio, resort
> tools/Makefile.am and update to classpath head. It would be nice if
> somebody could review these changes. Bootstrap with and without java
> maintainer mode on x86_64-linux-gnu succeeded, no regressions in the
> libjava and mauve testsuites.
>
>  Matthias
>
> libjava/
>
> 2008-10-22  Matthias Klose  <doko@ubuntu.com>
>
>        Import GNU Classpath (libgcj-import-20081022).
>
>        * Regenerate class and header files.
>        * Regenerate auto* files.
>
> libjava/classpath/
>
> 2008-10-17  Robert Lougher  <rob.lougher@gmail.com>
>
>        * native/jni/gtk-peer/gnu_java_awt_peer_gtk_CairoGraphics2D.c
>        (Java_gnu_java_awt_peer_gtk_CairoGraphics2D_cairoDrawGlyphVector):
>        Release 'fonts'.
>
> 2008-10-16  Tom Tromey  <tromey@redhat.com>
>
>        * tools/gnu/classpath/tools/jar/WorkSet.java (initSet): Use
>        foreach.  Change argument type.
>        (WorkSet): Change argument type.
>        * tools/gnu/classpath/tools/jar/Indexer.java (indexJarFile): Use
>        foreach.
>        * tools/gnu/classpath/tools/jar/Creator.java
>        (writeCommandLineEntries): Use foreach.
>        (getAllEntries): Likewise.
>
> 2008-09-16  Andrew John Hughes  <gnu_andrew@member.fsf.org>
>
>        * java/lang/System.java (getenv): Reinstate
>        use of EnvironmentMap as opposed to raw
>        HashMap.
>
> 2008-09-16  Mario Torre  <neugens@aicas.com>
>
>        * java/lang/System.java (getenv): Fix env entries of the form
>        key=value=value=value not parsed correctly.
>

Mostly looks good.  I'm concerned as to why this chunk is being
removed:

  if test "x${REGENERATE_GJDOC_PARSER}" = xyes; then
-dnl GCJ LOCAL
-      if test "x${enable_java_maintainer_mode}" = xyes; then
-        AC_PROG_JAVA
       AC_PROG_ANTLR(2,7,1)
-      fi
-dnl END GCJ LOCAL

Other than that, the Classpath ChangeLog updates seem to be missing
the ThreadLocal and NIO changes (one entry I think).

-- 
Andrew :-)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8