Re: libjava regressions in r140713

[Andreas Tobler <andreast-list at fgznet dot ch>]

Hi Peter,

Peter O'Gorman wrote:
> Andreas Tobler wrote:
> > Jack Howarth wrote:
> > >    On i686-apple-darwin9, I am seeing massive regressions in the libjava
> > > testsuite in revision 140713 compared to my previous test on 20080925.
> > > Since the libtool updates went in (which would see the likely culprit),
> > > we went from zero to 835 unexpected failures.
> > >
> > > http://gcc.gnu.org/ml/gcc-testresults/2008-09/msg02174.html
> > > http://gcc.gnu.org/ml/gcc-testresults/2008-09/msg02291.html
> > I'll send a patch later today.
>
> Thanks Andreas, libtool prints this warning for:
> *-*-cygwin* | *-*-mingw* | *-*-pw32* | *-*-os2* | *-*-darwin* | *-cegcc*
>
> So, the libjava testsuite's libjava.exp should probably avoid adding
> -no-install for a similar set of targets.

Hm, cygwin and mingw are already in, pw32, os2 and cegcc I never heared 
in combination with libjava and gcc.

So my first attempt I sent to java-patches would still be ok.
http://gcc.gnu.org/ml/java-patches/2008-q3/msg00103.html

But for completness I can add those targets as well.

Here what I have:

Index: testsuite/lib/libjava.exp
===================================================================
--- testsuite/lib/libjava.exp   (revision 140659)
+++ testsuite/lib/libjava.exp   (working copy)
@@ -422,7 +422,9 @@
     # Avoid libtool wrapper scripts when possible.
     # but not if libtool warnings results in FAILs
     if {$mode == "link"} {
-       if {! [istarget "*-*-cygwin*"] && ! [istarget "*-*-mingw*"] } {
+       if {! [istarget "*-*-cygwin*"] && ! [istarget "*-*-mingw*"]
+           && ! [istarget "*-*-darwin*"] && ! [istarget "*-*-pw32*"]
+           && ! [istarget "*-*-os2*"] && ! [istarget "*-cegcc*"] } {
            lappend args "additional_flags=-no-install"
        }
        if { [istarget "*-*-darwin*"] } {


Test are fine with this mod on darwin.

Thanks,
Andreas