This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: PR libgcj/23758, Fix theoretical race PosixProcess.
- From: Tom Tromey <tromey at redhat dot com>
- To: David Daney <ddaney at avtrex dot com>
- Cc: GCJ-patches <java-patches at gcc dot gnu dot org>
- Date: 09 Apr 2007 10:44:33 -0600
- Subject: Re: Patch: PR libgcj/23758, Fix theoretical race PosixProcess.
- References: <4619D39D.9020706@avtrex.com>
- Reply-to: tromey at redhat dot com
>>>>> "David" == David Daney <ddaney@avtrex.com> writes:
David> This patch moves the mallocs out of the danger zone in
David> natPosixProcess.cc
David> OK to commit?
Two nits -- fix these and it is ok.
David> + // explicitly. We need three extra slots. Potentailly PATH
Typo, should be "potentially".
David> + if (0 == strncmp (env[i], "PATH=", sizeof("PATH=")))
David> + need_path = false;
David> + if (0 == strncmp (env[i], "LD_LIBRARY_PATH=",
David> + sizeof("LD_LIBRARY_PATH=")))
David> + need_ld_library_path = false;
Use "! strncmp" instead. That's libgcj convention.
thanks,
Tom