This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [RFA] JVMTI Agent Loading
- From: Tom Tromey <tromey at redhat dot com>
- To: Kyle Galloway <kgallowa at redhat dot com>
- Cc: GCJ-patches <java-patches at gcc dot gnu dot org>
- Date: 04 Apr 2007 13:42:13 -0600
- Subject: Re: [RFA] JVMTI Agent Loading
- References: <460AC972.5080101@redhat.com> <m3vegi4h2s.fsf@localhost.localdomain> <460D7838.6080306@redhat.com> <m3wt0y313m.fsf@localhost.localdomain> <461256B8.2070905@redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Kyle" == Kyle Galloway <kgallowa@redhat.com> writes:
Kyle> I think I have all the changes made now, but I've attached a revised
Kyle> patch here in case there are any other issues before I check this in.
Just a couple little nits, please fix them & commit.
Thanks.
Kyle> +// If LTDL cannot be used, return an error code indicating this
Kyle> +return -99;
This is still not indented correctly.
Also, comments in libgcj are (or ought to be :-) full sentences
starting with a capital letter (unless there's a good reason why not)
and ending in a period. Most of the comments being added need a
little tweak here.
Tom