This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] JVMTI GetArgumentsSize


>>>>> "Kyle" == Kyle Galloway <kgallowa@redhat.com> writes:

Kyle> +    return static_cast<jint> (args_raw_size);

Kyle> +  *size = (imeth->get_args_size () / sizeof (_Jv_word));

I don't think we ought to assume that args_raw_size is a multiple of
sizeof(_Jv_word).  args_raw_size is computed by libffi and ought to be
treated as a black-box calculation, IMO.

Instead, write a loop to decode the method signature and compute the
result that way.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]