This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] JDWP single step callback


>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> Okay, at long, last, here is *the* patch. My last outstanding JVMTI/JDWP
Keith> patch that implements the meat of the single step notification.

Awesome!

How about making a patch to add a new news entry to the gcj web page?

Keith> +      fprintf (stderr, "libgcj: internal error: could not find class for method while single stepping -- continuing\n");

I'm not super happy about doing this but I see we already have some in
jvmti.cc.  And it isn't immediately clear what would be better.

Keith> +  jobject instance = NULL; // FIXME

What's up with this?  Just put a short explanation (a couple words,
say) in the FIXME and I think this patch is ok.  Thanks.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]