This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [RFA/JDWP] Implement VMVM:getFrames
- From: Tom Tromey <tromey at redhat dot com>
- To: Kyle Galloway <kgallowa at redhat dot com>
- Cc: Java Patch List <java-patches at gcc dot gnu dot org>
- Date: 13 Feb 2007 08:12:27 -0700
- Subject: Re: [RFA/JDWP] Implement VMVM:getFrames
- References: <45CC8EBA.9010401@redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Kyle" == Kyle Galloway <kgallowa@redhat.com> writes:
Kyle> This patch implements the final portion of JDWP stack tracing. what I
Kyle> have done here is to use VMVM:getFrame to get each frame and them just
Kyle> pack them into an array. It is also possible to have getFrames call
Kyle> JVMTI directly, but it think it would be better to have getFrame do
Kyle> the processing from JVMTI to a VMFrame to avoid having to duplicate
Kyle> much of that code. Are there other opinions?
If this approach is ok with Keith, it is ok with me.
Kyle> + // Only return length frames.
Kyle> + if (length != -1 && length-- <= 0)
Kyle> + break;
Why?
Tom