This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
[RFA] Remove unneeded casts from jvmti.cc
- From: Keith Seitz <keiths at redhat dot com>
- To: Java Patch List <java-patches at gcc dot gnu dot org>
- Date: Mon, 12 Feb 2007 18:25:44 -0800
- Subject: [RFA] Remove unneeded casts from jvmti.cc
Hi,
A recent check-in has reintroduced some unnecessary casts that were
eliminated a couple of weeks ago. This patch simply removes these
superfluous casts. [And it fixes a little formatting typo in the func decl.]
Ok?
Keith
ChangeLog
2007-02-09 Keith Seitz <keiths@redhat.com>
* jvmti.cc (_Jv_JVMTI_GetStackTrace): Remove cast
from jthread to Thread *; it is no longer needed.
(_Jv_JVMTI_GetFrameCount): Likewise.
Fix small formatting typo.
Index: jvmti.cc
===================================================================
--- jvmti.cc (revision 121766)
+++ jvmti.cc (working copy)
@@ -256,7 +256,7 @@
static jvmtiError JNICALL
_Jv_JVMTI_GetFrameCount (MAYBE_UNUSED jvmtiEnv *env, jthread thread,
- jint* frame_count)
+ jint *frame_count)
{
REQUIRE_PHASE (env, JVMTI_PHASE_LIVE);
@@ -265,12 +265,10 @@
using namespace java::lang;
THREAD_DEFAULT_TO_CURRENT (thread);
-
- Thread *thr = reinterpret_cast<Thread *> (thread);
- THREAD_CHECK_VALID (thr);
- THREAD_CHECK_IS_ALIVE (thr);
+ THREAD_CHECK_VALID (thread);
+ THREAD_CHECK_IS_ALIVE (thread);
- _Jv_Frame *frame = reinterpret_cast<_Jv_Frame *> (thr->frame);
+ _Jv_Frame *frame = reinterpret_cast<_Jv_Frame *> (thread->frame);
(*frame_count) = frame->depth ();
return JVMTI_ERROR_NONE;
}
@@ -826,10 +824,8 @@
using namespace java::lang;
THREAD_DEFAULT_TO_CURRENT (thread);
-
- Thread *thr = reinterpret_cast<Thread *> (thread);
- THREAD_CHECK_VALID (thr);
- THREAD_CHECK_IS_ALIVE (thr);
+ THREAD_CHECK_VALID (thread);
+ THREAD_CHECK_IS_ALIVE (thread);
jvmtiError jerr = env->GetFrameCount (thread, frame_count);
if (jerr != JVMTI_ERROR_NONE)
@@ -843,7 +839,7 @@
ILLEGAL_ARGUMENT (start_depth >= (*frame_count));
ILLEGAL_ARGUMENT (start_depth < (-(*frame_count)));
- _Jv_Frame *frame = reinterpret_cast<_Jv_Frame *> (thr->frame);
+ _Jv_Frame *frame = reinterpret_cast<_Jv_Frame *> (thread->frame);
// If start_depth is negative use this to determine at what depth to start
// the trace by adding it to the length of the call stack. This allows the