Re: Patch: RFC: fix ProcessBuilder; windows help needed

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Mohan" == Mohan Embar <gnustuff@thisiscool.com> writes:

Mohan> Reading
Mohan> HACKING, it seems that after I've applied the patch, with automake
Mohan> 1.96 and autoconf 2.59 in my path, I need to do this:
Mohan> ./scripts/makemake.tcl > sources.am
Mohan> automake

Yes.

Mohan>   "Possibly update the gcj/javaprims.h file with scripts/classes.pl
Mohan>   (See below, it can only be done after the first source->bytecode
Mohan>    pass has finished.)"
Mohan> Does this need to be done? You've added a java.lang.VMProcess.

Yeah, I did that.  But I think I may have omitted it from my patch, as
that section is generated.

Mohan> I think what the above means is passing --enable-maintainer-mode as
Mohan> a top-level configure flag, but I am stumped as to what "and you
Mohan> will need to update the .class files and generated CNI header files in
Mohan> your working tree" means.

If you --enable-java-maintainer-mode, then this ought to happen
automatically for you.

Mohan> To summarize, I'd like to know exactly what scripts to run
Mohan> after I apply your patch (and ideally, why I'm running them).

Download ecj.jar using the contrib/download_ecj method
Configure with --enable-java-maintainer-mode.
Apply patch.
./scripts/makemake.tcl > sources.am
automake
Build.
When the build fails, run classes.pl and insert output into javaprims.h
Rebuild

Mohan> I'd like to get up to speed on all of this, but if you're
Mohan> concerned about time, a faster path might be committing your
Mohan> changes and letting me pick of the pieces on the Win32
Mohan> side. Your call.

Better to iron this stuff out a little and see if any documentation
changes drop out :)

Tom