This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] JDWP implment getFrameCount


Tom Tromey wrote:
"Kyle" == Kyle Galloway <kgallowa@redhat.com> writes:

Kyle> This patch implements the JDWP method getFrameCount from Kyle> natVMVirtualMachine.cc. It calls jvmti->GetFrameCount then returns Kyle> the result.

Kyle>  gnu::classpath::jdwp::VMVirtualMachine::
Kyle>  getFrameCount (MAYBE_UNUSED Thread *thread)

Remove the MAYBE_UNUSED.

Kyle> + jthread thr = reinterpret_cast<jthread> (thread);

I think you shouldn't need this cast any more.

Ok with those changes. Assuming I'm right about the cast :)
I've made those changes and committed. You are correct, a jthread is now defined as a java::lang::Thread* so the cast was just creating another identical pointer to the same object.

Thanks,
Kyle


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]