This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [RFA] JVMTI Interpreted Tests
- From: Tom Tromey <tromey at redhat dot com>
- To: Kyle Galloway <kgallowa at redhat dot com>
- Cc: Java Patches <java-patches at gcc dot gnu dot org>
- Date: 24 Jan 2007 13:43:55 -0700
- Subject: Re: [RFA] JVMTI Interpreted Tests
- References: <45B7BA31.8080401@redhat.com>
- Reply-to: tromey at redhat dot com
Kyle> Comments, or can I commit this?
Just one change.
Kyle> +# Run the JVMTI tests.
Kyle> +proc gcj_jvmti_run {} {
[...]
Kyle> +
Kyle> +gcj_jvmti_run
Name this gij_jvmti_run.
It is ok to redefine procs in Tcl, but it is a bit clearer if they
have unique names. (I see you did this elsewhere so I guess you just
missed this one :)
This is ok with this change.
Tom