This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [RFC] JVMTI CLASS_PREPARE event
- From: Tom Tromey <tromey at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: Java Patch List <java-patches at gcc dot gnu dot org>
- Date: 24 Jan 2007 13:36:25 -0700
- Subject: Re: [RFC] JVMTI CLASS_PREPARE event
- References: <45B7CDDB.1030207@redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> The patch adds the JVMTI event notification for CLASS_PREPARE. This is
Keith> now the third or fourth place I've put this notification (at least),
Keith> and I know this is still not quite right. It's awfully close, but not
Keith> perfect.
Keith> I welcome suggestions, advice, comments, etc.
This looks good to me.
What is it you need to capture here? Maybe we can suggest a better
spot. Though, almost all state transitions happen here, so this is
pretty good.
Maybe wrap the condition in a builtin_expect?
Keith> + java::lang::Thread *thread = java::lang::Thread::currentThread ();
You could hoist the local variable 'self' outside the new scope and
reuse it. If you're into micro-optimization and all.
Tom