This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [RFA] Implement JVMTI GetClassStatus
- From: Tom Tromey <tromey at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: Java Patch List <java-patches at gcc dot gnu dot org>
- Date: 22 Jan 2007 15:07:02 -0700
- Subject: Re: [RFA] Implement JVMTI GetClassStatus
- References: <45B54D33.6050009@redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> This patch is an attempt to implement JVMTI's GetClassStatus
Keith> call. While I think I've got it right, I would appreciate it if
Keith> maintainers would scrutinize the internal class status flags to JVMTI
Keith> flag part to make sure I haven't botched anything.
Pretty close I think.
Keith> + if (gcj::verifyClasses)
Keith> + (*status_ptr) |= JVMTI_CLASS_STATUS_VERIFIED;
We've only verified the code if the state is >= JV_STATE_LINKED.
Keith> + else if (state > JV_STATE_IN_PROGRESS)
Keith> + (*status_ptr) |= JVMTI_CLASS_STATUS_INITIALIZED;
This test should probably just be 'state == JV_STATE_DONE'.
JV_STATE_PHANTOM is weird, and you don't want to handle JV_STATE_ERROR
this way either.
Ok with those changes, thanks.
Tom