This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: retracting my retraction [patch included]
- From: Mohan Embar <gnustuff at thisiscool dot com>
- To: Adam Megacz <megacz at cs dot berkeley dot edu>, tromey at redhat dot com
- Cc: java-patches at gcc dot gnu dot org, Marco Trudel <mtrudel at gmx dot ch>
- Date: Sat, 20 Jan 2007 00:05:35 -0600
- Subject: Re: retracting my retraction [patch included]
- Reply-to: gnustuff at thisiscool dot com
Hi All,
>Sorry about the delay on reading this.
>I finally read this whole thread.
>
>Adam> - GCJ="${target_noncanonical}-gcj -B`${PWDCMD-pwd}`/"
>Adam> + GCJ="$built_gcc_dir/gcj -B$built_gcc_dir/"
>
>I think this patch is probably causing problems for Marco.
>However I'm not certain.
Whoa. Did this actually get committed? In one of the follow-ups,
I pointed out that this was wrong and Andrew came around and
agreed with me. This hadn't gotten committed to the ecj branch
at the time that I was working on an alternative patch.
OK. Looking at SVN, I see this has been committed. This is wrong
for the reasons I mentioned in the followup and should be reverted:
http://gcc.gnu.org/ml/java-patches/2006-q4/msg00313.html
For some reason, this was applied against the mainline and not to
gcj-eclipse-merge-branch. I would have never thought to check
for this scenario when I saw Marco's emails.
-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/