Re: [cp-patches] cp-tools: fix build options

[Mark Wielaard <mark at klomp dot org>]

Hi Andrew,

On Sat, 2006-12-16 at 17:40 +0000, Andrew Haley wrote:
> Mark Wielaard writes:
>  > On Sat, 2006-12-16 at 15:48 +0000, Andrew Haley wrote:
>  > > Mark Wielaard writes:
>  > > > I couldn't find any documentation that describes what -w is
>  > >  > supposed to provide, so I don't really know what to suggest as
>  > >  > alternative. If this flag is compiler specific you might want to
>  > >  > add a configure flag and adjust the definition of JCOMPILER at the
>  > >  > top directly.
>  > > 
>  > > We need to turn off warnings during the build.  If we don't do that,
>  > > it's impossible to find any build errors.
>  > 
>  > It seems better to fix the warnings.
> 
> I agree, but that's at least a year away, I expect.  In the meantime
> we must turn off the warnings.

Lets just turn off the warnings that we also disable for the core
classes. It would be nice to re-enable the unchecked and varargsCast
warnings later on though. Also done for examples:

2006-12-17  Mark Wielaard  <mark@klomp.org>

    * examples/Makefile.am (JCOMPILER): Don't warn for deprecation,
    serial, typeHiding, unchecked, unused and varargsCast.
    * tools/Makefile.am (JCOMPILER): Likewise.

Committed,

Mark

Index: examples/Makefile.am
===================================================================
RCS file: /cvsroot/classpath/classpath/examples/Makefile.am,v
retrieving revision 1.18
diff -u -r1.18 Makefile.am
--- examples/Makefile.am	15 Dec 2006 22:09:28 -0000	1.18
+++ examples/Makefile.am	17 Dec 2006 16:28:50 -0000
@@ -9,7 +9,7 @@
 #JCOMPILER = $(JIKES) -bootclasspath '' -extdirs '' -sourcepath '' --classpath $(top_builddir)/lib:.
 #else
 if FOUND_ECJ
-JCOMPILER = $(ECJ) -1.5 -encoding UTF-8 -bootclasspath $(GLIBJ_CLASSPATH) -classpath .
+JCOMPILER = $(ECJ) -1.5 -encoding UTF-8 -warn:-deprecation,serial,typeHiding,unchecked,unused,varargsCast -bootclasspath $(GLIBJ_CLASSPATH) -classpath .
 else
 if FOUND_JAVAC
 JCOMPILER = $(JAVAC) -encoding UTF-8 -bootclasspath $(GLIBJ_CLASSPATH) -classpath .
Index: tools/Makefile.am
===================================================================
RCS file: /cvsroot/classpath/classpath/tools/Makefile.am,v
retrieving revision 1.36
diff -u -r1.36 Makefile.am
--- tools/Makefile.am	17 Dec 2006 16:20:11 -0000	1.36
+++ tools/Makefile.am	17 Dec 2006 16:28:50 -0000
@@ -5,7 +5,7 @@
 
 # Setup the compiler to use the GNU Classpath library we just built.
 if FOUND_ECJ
-JCOMPILER = $(ECJ) -1.5 -encoding UTF-8 -bootclasspath $(GLIBJ_BOOTCLASSPATH) -classpath .:$(GLIBJ_CLASSPATH)
+JCOMPILER = $(ECJ) -1.5 -encoding UTF-8 -warn:-deprecation,serial,typeHiding,unchecked,unused,varargsCast -bootclasspath $(GLIBJ_BOOTCLASSPATH) -classpath .:$(GLIBJ_CLASSPATH)
 else
 if FOUND_JAVAC
 JCOMPILER = $(JAVAC) -encoding UTF-8 -bootclasspath $(GLIBJ_BOOTCLASSPATH) -classpath .:$(GLIBJ_CLASSPATH)

Attachment: signature.asc
Description: This is a digitally signed message part