This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: jvmti patch for mingw32
- From: Marco Trudel <mtrudel at gmx dot ch>
- To: gnustuff at thisiscool dot com
- Cc: Java Patch List <java-patches at gcc dot gnu dot org>
- Date: Sat, 23 Sep 2006 10:46:17 +0200
- Subject: Re: jvmti patch for mingw32
- References: <9TQZ31XCBE9A9MJJGSMLIGCNKUSWT.4514532c@d9300>
Mohan Embar wrote:
Hi Marco,
I don't mean to be annoying, but could you submit the
patch exactly like I've done here?:
Actually you're not annoying. I'm glad you take the time to tell me
these things. At last, I'm not here to make things more complicated than
they have to be...
- put the patch inline in the body of the email message and not
as an attachment
Following the later messages, I will stay with attached patches. I use
thunderbird :-( Actually I attached them because I once tried to use an
inlined patch from the list, but it just didn't work because Thunderbird
broke it or I copied it wrong...
- the ChangeLog entry shouldn't be in diff format
But you meant the ChangeLog file in the dir? Or did you mean the log for
committing into subversion?
So I guess you just expected a line of text describing the changes?
- the jvmti.cc should be generated via "svn diff jvmti.cc"
when you're in the libjava directory. (I'm assuming you've
been working with svn a lot.)
That will work...
Is the svn diff using the same style as "diff -Naur"?
The reason I'm being so annoying is so that you learn to
do this properly if you submit other patches in the future.
That's ok...
Marco