Re: [RFA/JVMTI] New JVMTI Environment Initialization/Allocation

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> I've also snuck in another little patch which adds another common test
Keith> macro, this time for JVMTI_ERROR_ILLEGAL_ARGUMENT.

I noticed that this macro has no trailing ';' but NULL_CHECK does have
one.  The semicolon should probably be removed from NULL_CHECK.

Keith> [Heaven help me if my linked list impl is off. I'm not used to not
Keith> using JCL or STL anymore!]

Looks good to me.  Please commit.

Keith> +    if (_jvmtiEnvironments == NULL)
Keith> +      _jvmtiEnvironments = element;
Keith> +    else
Keith> +      {
Keith> +	struct jvmti_env_list *e;
Keith> +	for (e = _jvmtiEnvironments; e->next != NULL; e = e->next) ;
Keith> +	e->next = element;
Keith> +      }
Keith> +  }

Do we care about the order of the list?

FWIW, for an empty loop I tend to put the ';' on a line by itself, to
emphasize it.

Tom