This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [JAVA] /bin/sh portability issues in scripts/jar.in
- From: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>
- To: Roger Sayle <roger at eyesopen dot com>
- Cc: java-patches at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org, Paolo Bonzini <bonzini at gnu dot org>
- Date: Fri, 07 Jul 2006 08:33:55 +0200
- Subject: Re: [JAVA] /bin/sh portability issues in scripts/jar.in
- References: <Pine.LNX.4.44.0607062223160.25931-100000@www.eyesopen.com>
Roger Sayle wrote:
The following patch is the third in the series to allow use of the
native /bin/sh on Solaris/x86. These changes allow Paolo Bonzini's
impressive "jar" script to be used to build libjava on i386-pc-solaris2.10.
Thanks.
The change to the function "copy" replaces the use of the test's "-e"
operator, which isn't available on solaris, with the more portable "-f".
Note that there is another "test -e" a couple of lines below: in fact it
is safe to convert the one you changed to "test -f", but not the other
one. That one would give a wrong error message if changed. But it is
only triggered when there are errors, so we can live with it.
The second change avoid the "mkdir_p: command not found" error messages.
If I get to choose, I'd prefer _mkdir_p.
My 2 cents,
Paolo